Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset immunity effects always #788

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

Vaqtincha
Copy link
Contributor

No description provided.

@RauliTop
Copy link
Contributor

RauliTop commented Dec 3, 2022

Why? How about if are we using a plugin to add these effects?
and why you set the STATUSICON_HIDE out of the condition?

Cvar check is a must.

@Vaqtincha
Copy link
Contributor Author

Vaqtincha commented Dec 3, 2022

Cvar check is a must.

No!

set mp_respawn_immunitytime to a higher value (e.g. 10) and after the player spawns immediately set mp_respawn_immunity_effects to 0 and he will use this effect throughout the map after the end of the protection.

As for the status icon, yes I agree (but this is not my cant)

@SergeyShorokhov SergeyShorokhov added the Type: 🐞 bug An error that needs fixing. label Dec 13, 2022
@SergeyShorokhov SergeyShorokhov self-requested a review December 13, 2022 14:52
Copy link
Member

@SergeyShorokhov SergeyShorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a new m_bProtectionEffects memeber to CSPlayer and use it.

@Vaqtincha

This comment was marked as outdated.

@SergeyShorokhov
Copy link
Member

m_bProtectionEffects

There will be no benefit from this member for api.

Better to use iuser3 ? (like PLAYER_IN_BOMB_ZONE)

Using a network member is not the best solution.

@SergeyShorokhov SergeyShorokhov changed the title Reset immunity effects always fix: Reset immunity effects always Dec 15, 2022
@SergeyShorokhov SergeyShorokhov merged commit 9801627 into rehlds:master Dec 15, 2022
@Vaqtincha Vaqtincha deleted the fix_imm_eff branch December 15, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: 🐞 bug An error that needs fixing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants