Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CVar: mp_give_c4_frags #776

Merged
merged 18 commits into from
Oct 8, 2022
Merged

Conversation

JulioBarker
Copy link
Contributor

@JulioBarker JulioBarker commented Oct 2, 2022

// How many bonuses (frags) will get the player who defused or exploded the bomb.
// 3 - (default behaviour)
//
// Default value: "3"
mp_give_c4_frags 3

@SergeyShorokhov
Copy link
Member

SergeyShorokhov commented Oct 2, 2022

I propose to make not a Boolean switch, but a CVar with the number of frags for the actions of the bomb.

mp_give_c4_frags "3"
mp_give_c4_frags "-10"
mp_give_c4_frags "0"

@SergeyShorokhov SergeyShorokhov changed the title Add cvar: mp_give_c4_frags New CVar: mp_give_c4_frags Oct 2, 2022
@SergeyShorokhov SergeyShorokhov self-requested a review October 2, 2022 14:46
@SergeyShorokhov SergeyShorokhov added Type: 🚀 enhancement Improvement or addition of a new feature. Priority: 🕒 low Low priority tasks that can be postponed for the future. labels Oct 2, 2022
@abecee
Copy link

abecee commented Oct 2, 2022

I propose to make not a Boolean switch, but a CVar with the number of frags for the actions of the bomb.

mp_give_c4_frags "3"
mp_give_c4_frags "-10"
mp_give_c4_frags "0"

Yep..this will be more useful then 0 and 1 command. For me i want to change the value's frags with wich number i want.

regamedll/dlls/game.cpp Outdated Show resolved Hide resolved
regamedll/dlls/game.cpp Outdated Show resolved Hide resolved
dist/game.cfg Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
regamedll/dlls/ggrenade.cpp Outdated Show resolved Hide resolved
@abecee
Copy link

abecee commented Oct 8, 2022

Will be this added in the next update ?

@SergeyShorokhov SergeyShorokhov merged commit 83151aa into rehlds:master Oct 8, 2022
@Vaqtincha
Copy link
Contributor

Vaqtincha commented Oct 9, 2022

The name cvar is inaccurate and incomprehensible. Not a hint about the defuser.

PS: as always, sergey was again in a hurry to accept unnecessary and useless pull requests

@SergeyShorokhov
Copy link
Member

SergeyShorokhov commented Oct 9, 2022

@Vaqtincha @etojuice 😒

Not a hint about the defuser.

and "not a hint about the exploder"
If anyone has suggestions for better naming - happy to accept, I will correct.

@deprale
Copy link
Contributor

deprale commented Feb 21, 2023

and "not a hint about the exploder" If anyone has suggestions for better naming - happy to accept, I will correct.

// How many points(frags) will the player be awarded for completing the objective (defuse/explode c4)
// 3 - (default behaviour)
//
// Default value: "3"
mp_objective_bonus 3

@SergeyShorokhov
Copy link
Member

mp_objective_bonus 3

Map objective can be different. de_, cs_, es_ and etc...

@deprale
Copy link
Contributor

deprale commented Feb 21, 2023

mp_objective_bonus 3

Map objective can be different. de_, cs_, es_ and etc...

Yes, objective bonus sounds good then no? Because it is universal, only need to change the wording a little bit in the description to not only include c4.

Defuse/plant(de)
Save VIP (as)
Save Hostages (cs)

I thought about different game modes but didn't check what the actual commit do, I just supposed it changed C4 score behaviour based on the cvar name 😅

@SergeyShorokhov
Copy link
Member

https://github.com/s1lentq/ReGameDLL_CS/blob/d8702df5482d8945dff4ef5005261ffbc8b29343/regamedll/dlls/ggrenade.cpp#L1443

  • that PR refers only to bomb bonus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 🕒 low Low priority tasks that can be postponed for the future. Type: 🚀 enhancement Improvement or addition of a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants