Disable thread-safe initialization for static local variables #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…15+ when XP toolset is used.
s1lentq
approved these changes
Sep 7, 2021
|
I love that! If those Re* binaries could run under XP that will be nice! And also make my life easier for my own tests of them. @jeefo: Maybe you should tell to GitHub devs that to do in order to make the interfaces handle XP properly, because this is not the case, GitHub too much fucked up under XP! Hehehehehe! |
SergeyShorokhov
added
Priority: 🕒 low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread local storage (TLS) in shared libraries loaded by LoadLibrary() is not completely supported on Windows XP / Server 2003, causing game to crash if run on this platforms. But ReGamedDLL uses v140_xp platform toolset with GitHub Actions when building windows binary, assuming that XP/2003 must be supported.
This only affects VS2015+ builds, so we're not checking v120_xp toolset.
Probably the same should be applied for ReHLDS to support Windows XP properly.