Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CGib::SpawnHeadGib and CGib::SpawnRandomGibs #650

Conversation

FEDERICOMB96
Copy link
Contributor

@FEDERICOMB96 FEDERICOMB96 commented Jun 20, 2021

@SergeyShorokhov SergeyShorokhov self-requested a review June 21, 2021 10:28
@FEDERICOMB96 FEDERICOMB96 changed the title API: Implemented SpawnHeadGib and SpawnRandomGibs API: Implemented CGib::SpawnHeadGib and CGib::SpawnRandomGibs Jun 26, 2021
@SergeyShorokhov SergeyShorokhov self-requested a review June 26, 2021 13:33
@SergeyShorokhov SergeyShorokhov requested a review from s1lentq June 26, 2021 13:34
@SergeyShorokhov SergeyShorokhov added Difficulty: 🟡 medium Task of medium difficulty requiring moderate effort. Status: ✅ done The issue done and closed. Type: 🚀 enhancement Improvement or addition of a new feature. labels Jun 26, 2021
@Vaqtincha
Copy link
Contributor

It's useless. Any entity can be created using rg_create_entity.

@Vaqtincha
Copy link
Contributor

Vaqtincha commented Jun 28, 2021

Then let's create natives for each entity. rg_spawn_defuser rg_spawn_hostage rg_spawn_weaponbox ...

@metita
Copy link
Contributor

metita commented Jun 28, 2021

Not sure if you are serious or not but did you even tried to do what are you implying? Based on what you say there are plenty of things that are implemented on ReAPI that can be done through members, entvars or create_entity, you are not forced to use these natives but then stick to your own methods, things like these makes programming easier for the end user.

@Vaqtincha
Copy link
Contributor

No need for rubbish api with unnecessary natives.

That's why today's programmers are so lazy.

@metita
Copy link
Contributor

metita commented Jun 28, 2021

Your argument is pretty vague honestly, again, based on your statement just keep RegisterHookChain/set/get_entvar and set/get_member and just let people do their job in a hard way? Maybe you should go and google what is a Framework or how libraries/API works, maybe you will notice a common pattern which is making programmer life easier, by the way not everyone is cappable of making a functional code even with everything ready or how to use on their respective docs.

#636 this is easily programmable.
#621 You can add StatusIcon too via AMXX :)
#555 Hey this can be made too!
#539 Does not ReAPI has a hook for falldamage? Or I am wrong?
#600 You seems to be a crybaby, noticed some pattern there too, don't give up))
#454 ^

Just to contribuite this Pull Request, this is part of complementing this implementation by fl0werD rehlds/ReAPI#164 just to make everything chained and functionally without workarounds.

@Vaqtincha
Copy link
Contributor

Absolutely wrong comparison. It looks like you yourself do not know what api is. Try to do something first

@Vaqtincha
Copy link
Contributor

"#555 Hey this can be made too!"

you won't do it.

all my commits are made to exclude amxmod dependency.

@Vaqtincha
Copy link
Contributor

your api is only needed for one plugin. don't be smart here

@Vaqtincha
Copy link
Contributor

Vaqtincha commented Jun 28, 2021

Ясно с размышлением оленей.
Этих ты
#636
#555
#600
фиг программируешь.

Да видел ваших костылей на оленах. А мой работает сто раз лучше чем у вас. Лол даже не знает различия между кваром и апи.

Спор окончен!

@metita
Copy link
Contributor

metita commented Jun 28, 2021

In fact I do not need anything from ReAPI/ReGameDLL because it already offers what I need.

Uhm yeah, making random spawns is pretty easy through AMXX, I am not trying to be smart or anything, just making a point on your argument (can be considered as that? seems just a complain for nothing), you have good pull request and issues, not gonna lie, but your statement regarding this one just make nonsense, please, take a look at ReGameDLL and ReAPI main page, pull request are welcomed and are presented as a powerful and extended API for mods/plugins.

ReGameDLL goals:

Provide more stable (than official) version of Counter-Strike game with extended API for mods and plugins
...
Merge requests are also welcome

Instead of not adding content just because it it useless (?), if you do not need it, just do not use it, more people will find it useful and whoever has a use will be grateful for this implementation rather than searching for a workarounds.

@Vaqtincha
Copy link
Contributor

@metita I will not argue with a fool. good luck

@metita
Copy link
Contributor

metita commented Jun 28, 2021

By the way, I tried to have a good discussion with you but looks like I was not wrong at all with your attitude, sadly.
Maybe try to search how I have contributed to the game (half-life repo), but that's not how it works, at the end just s1lent have the final word 👍

@Vaqtincha
Copy link
Contributor

"Uhm yeah, making random spawns is pretty easy through AMXX"

show me at least one normal random generator. you have no idea how it works.

@fl0werD
Copy link
Contributor

fl0werD commented Jul 3, 2021

That's why today's programmers are so lazy.

Yes, how dare they make their job easier!

@StevenKal
Copy link
Contributor

StevenKal commented Aug 22, 2021

"#600 You seems to be a crybaby, noticed some pattern there too, don't give up))"

I love that! Hehehe!
Yeah, please do not give up! Or just push that #600 as it is, this will be at least better than "nothing"!


About the submition of those gib functions, well, more functions we have, better this is. And adding some in that structure is not gonna hurt, especially knowning the internal code of those gibs functions can call a lot of things and at the end, this will make programmers job easier...
This list of functions (ReGameFuncs_t) is even too poor and could be filled massively...

But obviously we have to avoid puting "duplicate/similar" code already existing on other binaries (for simplicity), which can also maybe make the coders a bit lost.

So yeah, those functions should be added.

@SergeyShorokhov SergeyShorokhov changed the title API: Implemented CGib::SpawnHeadGib and CGib::SpawnRandomGibs Implement CGib::SpawnHeadGib and CGib::SpawnRandomGibs Aug 31, 2021
@SergeyShorokhov SergeyShorokhov merged commit 8093d31 into rehlds:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: 🟡 medium Task of medium difficulty requiring moderate effort. Status: ✅ done The issue done and closed. Type: 🚀 enhancement Improvement or addition of a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants