-
-
Notifications
You must be signed in to change notification settings - Fork 204
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
23 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
593d1e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never forget to "push" the API version (as it has been sometimes forgotten, especially in ReHLDS)!
Please update it to v5.14.
593d1e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Back-compatibility isn't broken.
593d1e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1: To be able to know if the "ReGameDLL_CS" binary on a server can handle this function (via version check), so you can know, on a plugin, if such function (in this case, the "CCSPlayerItem::GetItemInfo"), can be used or not, and adapt your code regarding this (including error message & plugin pause).
Note: But on such case, I'll personnaly directly use the member value (CCSPlayerItem's "m_ItemInfo") for more reliability with older versions, since it was added much before and can be supported on older versions of ReGameDLL_CS.
#2: API version is usually updated when new hook chain(s) are added, those last are added "at the suite of the list" and do not break backward compatibility too, so why not do it there too?
Note: Plugins using latest hook chains, have to check if the current ReGameDLL_CS can support a specific hook chain, that's all (same as above).
#3: There is nothing "wrong" at increasing the API version everytime the external API (usable by Metamod's modules) is updated.
#4: I'm currently finalizing "my own version" of the ReAPI module for AMX Mod, builded myself from scratch and completely different than the AMX Mod X's one by original Re* projects authors, and each function includes a version check related to "the one it needs" in order to properly know if this can be used or not (whatever for functions or hook chains). Maybe you do not care, or maybe, again, I'll receive some "get the f*** out", blablabla! But I've just wanted to add a "one more real, final & useful reason".
593d1e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne vous ai pas crié dessus ! Cependant, je devrai le faire pour le fait d'écrire en Russe ! Ce qui me casse les couilles, encore & encore...
593d1e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alexandr Sabitov, [2/14/20, 3:48 AM]
нарушается совместимость или нет?
s1lent, [2/14/20, 1:31 PM]
nope
593d1e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flowerd:
Where those messages did they go?! I guess repository owner can "s1lently" remove them! Or, you removed your message(s) letting mine in a "stupid monologue"? Hum...
But well, I've seen s1lent has just updated the API a few minuts ago, so problem solved. Good.
593d1e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted my msgs.