Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cssdk_const.inc: add ScoreAttrib constants #214

Merged
merged 3 commits into from
Oct 23, 2021

Conversation

Nord1cWarr1or
Copy link
Contributor

@fl0werD
Copy link
Contributor

fl0werD commented Sep 6, 2021

https://github.com/s1lentq/reapi/blob/e808d72075f5018336c15955f8d2d68e8f2cc084/reapi/include/cssdk/dlls/cdll_dll.h#L63-L65
what's about it?

@Nord1cWarr1or
Copy link
Contributor Author

https://github.com/s1lentq/reapi/blob/e808d72075f5018336c15955f8d2d68e8f2cc084/reapi/include/cssdk/dlls/cdll_dll.h#L63-L65

what's about it?

Oh, I didn't know about these constants.
I can redo it with these names. (and add new constants to that file at the same time)

Like: https://github.com/s1lentq/ReGameDLL_CS/blob/f57d28fe721ea4d57d10c010d15d45f05f2f5bad/regamedll/dlls/cdll_dll.h#L63-L66 (one more const)

@Nord1cWarr1or
Copy link
Contributor Author

@fl0werD can you also tell me, why in your example, here is constants with BIT() macros, and in cssdk_const.inc is not. Which I sholud use?

@fl0werD
Copy link
Contributor

fl0werD commented Sep 7, 2021

@fl0werD can you also tell me, why in your example, here is constants with BIT() macros, and in cssdk_const.inc is not. Which I sholud use?

It's for compatibility to another includes with same macroses names (like in hlsdk_const.inc) included in one plugin. I don't see these macroses in another includes but this truth.

Nord1cWarr1or added a commit to Nord1cWarr1or/ReGameDLL_CS that referenced this pull request Sep 7, 2021
Nord1cWarr1or added a commit to Nord1cWarr1or/ReGameDLL_CS that referenced this pull request Sep 7, 2021
@SergeyShorokhov SergeyShorokhov changed the title cssdk_const.inc: add ScoreAttrib constants cssdk_const.inc: add ScoreAttrib constants Oct 23, 2021
@SergeyShorokhov SergeyShorokhov self-requested a review October 23, 2021 10:04
@SergeyShorokhov SergeyShorokhov added the Type: 🚀 enhancement Improvement or addition of a new feature. label Oct 23, 2021
@SergeyShorokhov SergeyShorokhov merged commit 3c9e583 into rehlds:master Oct 23, 2021
SergeyShorokhov pushed a commit to rehlds/ReGameDLL_CS that referenced this pull request Oct 28, 2021
* cdll_dll.h: add `SCORE_STATUS_NONE` constant

* player.cpp: SetScoreAttrib: add `SCORE_STATUS_NONE` constant

related to rehlds/ReAPI#214
@Nord1cWarr1or Nord1cWarr1or deleted the Nord1cWarr1or-patch-1 branch December 20, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: 🚀 enhancement Improvement or addition of a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants