Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added kwargs argument to builder subparser in main for builder comman… #1037

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

davidkim1
Copy link
Contributor

…d to accept kwargs as argument

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1037 (1ad23e2) into main (4a69952) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   69.61%   69.61%           
=======================================
  Files          76       76           
  Lines        8454     8455    +1     
=======================================
+ Hits         5885     5886    +1     
  Misses       2569     2569           
Files Coverage Δ
regolith/main.py 95.79% <100.00%> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a69952...1ad23e2. Read the comment docs.

@sbillinge
Copy link
Contributor

This looks good. I forgot to tell you to make a news

  1. look in the directory called news
  2. find a file called TEMPLATE.rst
  3. copy it to a new name with the <name of your branch>.rst
  4. This is the information that will go into the changelog when we release it. Since you added the passing of kwargs in the builder, under "Added" add a bullet that says "new functionality that allows general kwargs to be passed to builders from the command line"
  5. Add and commit this file and push to the PR.

Typically there is one news per PR. Because people are not good at making good commit messages we use this to handle the public-facing release changelog rather than listing commit messages.

@sbillinge sbillinge merged commit fca28a5 into regro:main Oct 10, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants