-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle constraints from run_exports #30
Conversation
previous handling added any unrecognized keys (e.g. strong_constrains) to weak requirements resulting in "package not found: strong_constrains" and constraints being ignored
Thanks for this! Edit: we need to add the constrains bits as predicates to the solver. @jaimergp should be able to guide us on how to do that. |
both weak and strong apply from host environment, not just weak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @minrk. My initial comment was wrong and we should not be adding constraints to the host or run deps. I will back those commits out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back these out.
Makes sense, sorry. I think I see how to apply constraints as actual constraints instead of dependencies, if you want to go that way. I can do it as another PR, since this fixes the immediate problem and nobody has complained about lacking constraints so far, as far as I know. |
Sorry, just saw the ping. I guess it's not necessary anymore to discuss the solver constraints? |
Cool, ping me in the new PR once ready :) |
weak_constrains
andstrong_constrains
keys in run_exportsI initially added the constraints to the dependencies for the solve, since right now they are ignored, but I'm not sure that's the right thing to do, so I backed it out.
previous handling added any unrecognized keys (e.g. strong_constrains) to weak requirements, resulting in:
seen in the petsc321 migrator in dolfinx_mpc, specifically this run.