Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added migrator for aarch64 and ppc64le #444

Merged
merged 4 commits into from
Jan 29, 2019

Conversation

mariusvniekerk
Copy link
Contributor

This is a basic migrator for doing the Arch rebuild.

  • We are purposefully ignoring noarch here and initially operating within a bounded set of packages.
  • In order to determine if a package is migrated we take a look inside the conda-forge-config.yml and check for certain values. If those are present a package is skipped.
  • The current set of constraints yields about 120 packages to run this migrator on.

Additionally, this also adds a refactor to allow using distributed instead of multiprocessing for performing the initial graph building.

migrators.append(
ArchRebuild(graph=total_graph,
pr_limit=5,
name='aarch64 and ppc64le addition',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If azure doesn't support [skip ci] [ci skip], then we can add it here so that other CI doesn't run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the other platforms support something like [skip appveyor] [skip travisci] [skip circle] ?

Feels a tad dangerous relying on a relatively common feature not existing :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appveyor does. Travis-CI can be implemented using conditions. For circle, we can modify fast-finish script

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we at least do [skip appveyor] before we do this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind putting in a PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a issue at #452

@codecov-io
Copy link

codecov-io commented Jan 26, 2019

Codecov Report

Merging #444 into master will decrease coverage by 1.03%.
The diff coverage is 4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
- Coverage   29.21%   28.17%   -1.04%     
==========================================
  Files           8        8              
  Lines         623      653      +30     
==========================================
+ Hits          182      184       +2     
- Misses        441      469      +28
Impacted Files Coverage Δ
conda_forge_tick/update_upstream_versions.py 25.65% <0%> (-0.33%) ⬇️
conda_forge_tick/make_graph.py 0% <0%> (ø) ⬆️
conda_forge_tick/utils.py 69.74% <21.42%> (-6.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4cc58...0aada2d. Read the comment docs.

conda_forge_tick/auto_tick.xsh Outdated Show resolved Hide resolved
conda_forge_tick/migrators.xsh Outdated Show resolved Hide resolved
@scopatz
Copy link
Contributor

scopatz commented Jan 28, 2019

Seems to be failing CI

@mariusvniekerk
Copy link
Contributor Author

ah its failing because of the moved out r stuff

Copy link
Member

@CJ-Wright CJ-Wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants