-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added migrator for aarch64 and ppc64le #444
Conversation
migrators.append( | ||
ArchRebuild(graph=total_graph, | ||
pr_limit=5, | ||
name='aarch64 and ppc64le addition', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If azure doesn't support [skip ci] [ci skip]
, then we can add it here so that other CI doesn't run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the other platforms support something like [skip appveyor] [skip travisci] [skip circle] ?
Feels a tad dangerous relying on a relatively common feature not existing :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appveyor does. Travis-CI can be implemented using conditions. For circle, we can modify fast-finish script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we at least do [skip appveyor]
before we do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind putting in a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a issue at #452
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
==========================================
- Coverage 29.21% 28.17% -1.04%
==========================================
Files 8 8
Lines 623 653 +30
==========================================
+ Hits 182 184 +2
- Misses 441 469 +28
Continue to review full report at Codecov.
|
Seems to be failing CI |
ah its failing because of the moved out r stuff |
9f96644
to
0aada2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm thank you very much!
This is a basic migrator for doing the Arch rebuild.
Additionally, this also adds a refactor to allow using
distributed
instead ofmultiprocessing
for performing the initial graph building.