Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip all migrators on schema v1 for now #3006

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Sep 19, 2024

This PR skips all migrators on the v1 schema for now.

closes #2918

@wolfv
Copy link
Contributor

wolfv commented Sep 19, 2024

Thanks, looks good!

@beckermr beckermr merged commit f2cf34b into main Sep 19, 2024
5 checks passed
@beckermr beckermr deleted the filter-v1-add-schema-version branch September 19, 2024 16:04
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 79.66102% with 12 lines in your changes missing coverage. Please review.

Project coverage is 76.29%. Comparing base (3001670) to head (799f214).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/feedstock_parser.py 25.00% 6 Missing ⚠️
conda_forge_tick/migrators/core.py 72.72% 3 Missing ⚠️
conda_forge_tick/migrators/cross_compile.py 90.00% 1 Missing ⚠️
conda_forge_tick/migrators/jinja2_vars_cleanup.py 50.00% 1 Missing ⚠️
conda_forge_tick/migrators/numpy2.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3006      +/-   ##
==========================================
+ Coverage   76.28%   76.29%   +0.01%     
==========================================
  Files         115      115              
  Lines       12532    12550      +18     
==========================================
+ Hits         9560     9575      +15     
- Misses       2972     2975       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants