Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to continue support es5 #562

Merged
merged 2 commits into from
May 27, 2020
Merged

Fix to continue support es5 #562

merged 2 commits into from
May 27, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 27, 2020

@rreusser FYI - on plotly.js repo we had problem upgrading because of those es6 keywords.

@rreusser rreusser merged commit 14997ef into regl-project:master May 27, 2020
@archmoj archmoj deleted the support-es5 branch May 27, 2020 16:33
@rreusser
Copy link
Member

Thanks for the PR, @archmoj! It looks good and passes tests, so I've published this as v1.5.1. I tried adding parserOptions to the standard config in package.json, but didn't immediately succeed in enforcing ES5 as part of the tests in order to prevent this from happening in the future. I'm sure it's not hard, but I'd have to dig a bit deeper to figure out the right trick to get standard to accept this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants