Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency rustc-ap-arena failing on 1.29.0 nightly #21

Closed
nastevens opened this issue Jul 15, 2018 · 6 comments
Closed

Dependency rustc-ap-arena failing on 1.29.0 nightly #21

nastevens opened this issue Jul 15, 2018 · 6 comments

Comments

@nastevens
Copy link

Running cargo +nightly install cargo-modules gives

$ rustup run nightly cargo install cargo-modules
rustc 1.29.0-nightly (254f8796b 2018-07-13)

$ cargo +nightly install cargo-modules

<snip successful module compilations>

   Compiling rustc-ap-arena v154.0.0                                  
error[E0658]: use of unstable library feature 'raw_vec_internals': implemention detailrustc-ap-rustc_target, rust...
  --> /Users/nick/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-arena-154.0.0/lib.rs:46:5   
   |                                                                            
46 | use alloc::raw_vec::RawVec;                                     
   |     ^^^^^^^^^^^^^^^^^^^^^^                                                       
   |                                                                                                   
   = help: add #![feature(raw_vec_internals)] to the crate attributes to enable 
                                                                                     
error[E0658]: use of unstable library feature 'raw_vec_internals': implemention detail
  --> /Users/nick/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-arena-154.0.0/lib.rs:67:14  
   |                                                                            
67 |     storage: RawVec<T>,                                      
   |              ^^^^^^^^^                                                           
   |                                                                                                   
   = help: add #![feature(raw_vec_internals)] to the crate attributes to enable

<snip multiple repetitions of the previous error>

error: Could not compile `rustc-ap-arena`.
warning: build failed, waiting for other jobs to finish...
error: failed to compile `cargo-modules v0.4.1`, intermediate artifacts can be found at `/var/folders/vt/d9_pfw9j10l8jn69g02rjy1h0000gn/T/cargo-installsyJ6gK`
@regexident
Copy link
Owner

@nastevens, thanks for reporting! 👍

@hmvp any idea what might have cause this to break? RawVec has been in use in libarena for a while. 🤔

@mbudde
Copy link

mbudde commented Jul 19, 2018

I guess it's this: rust-lang/rust@1acbb0a935 (rust-lang/rust#51569)

hmvp added a commit that referenced this issue Jul 27, 2018
Apparently the old version is not buildable on new nightlies
This also forces some updates in the code since stuff has changed
regexident pushed a commit that referenced this issue Jul 28, 2018
Apparently the old version is not buildable on new nightlies
This also forces some updates in the code since stuff has changed
@hmvp
Copy link
Contributor

hmvp commented Aug 3, 2018

Fixed with #22

@hmvp hmvp closed this as completed Aug 3, 2018
@jan-hudec
Copy link

Please be so kind and release the bugfix too (to crates.io).

@regexident
Copy link
Owner

@jan-hudec, @nastevens I just pushed v0.4.2 to crates.io.
Sorry for taking so long. I simply forgot. 😇

@jan-hudec
Copy link

@regexident, thanks.

Unfortunately the GitHub issue tracker does not have any support for keeping track of which issues are fixed in master, but not released, so it is kind of easy to forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants