-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(math): adding Dec.SdkIntTrim #988
Conversation
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
==========================================
- Coverage 72.35% 72.34% -0.02%
==========================================
Files 212 212
Lines 23508 23521 +13
==========================================
+ Hits 17009 17016 +7
- Misses 5137 5144 +7
+ Partials 1362 1361 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Not sure what will get merged first, so might be nice to create an issue to update buy_direct with this utility function
Co-authored-by: Ryan Christoffersen <[email protected]>
The whole library. In SDK we don't use apd. |
We should be thinking about upstreaming this |
Description
Closes: #987
Benchmarks:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change