-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update changelog for v2.0.0 #486
Conversation
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 76.97% 76.97%
=======================================
Files 101 101
Lines 12531 12531
=======================================
Hits 9646 9646
Misses 2281 2281
Partials 604 604
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo, one formatting issue, and some observations. Pre-approving.
* [#385](https://github.com/regen-network/regen-ledger/pull/385) add support for credit cancelling | ||
* [#425](https://github.com/regen-network/regen-ledger/pull/425) add params for an allowlist of permissioned credit designers | ||
* [#451](https://github.com/regen-network/regen-ledger/pull/451) add queries to list classes and batches with a class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three are issues rather than pull requests. I think it's ok to link the issue but I just thought I might point that out. You can use /issue/
or /pull/
and the links resolve either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think in general we should probably be sticking w/ PRs. Saw that some issues snuck in but I was a bit lazy to check them in detail. Let's try and keep practice of using PRs in changelog moving forward.
* [#392](https://github.com/regen-network/regen-ledger/pull/392) update class ID and batch denomination formats | ||
* [#328](https://github.com/regen-network/regen-ledger/pull/328) record retirement locations of ecocredit | ||
* [#393](https://github.com/regen-network/regen-ledger/pull/393) add dates as top level fields in credit batches | ||
* [#394](https://github.com/regen-network/regen-ledger/pull/394) add project location as field in credit batches | ||
* [#435](https://github.com/regen-network/regen-ledger/pull/435) use dec wrapper for decimal operations | ||
* [#424](https://github.com/regen-network/regen-ledger/pull/424) add credit types to credit class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. These are all issues but no changes required.
CHANGELOG.md
Outdated
* ([#482](https://github.com/regen-network/regen-ledger/pull/482), | ||
[regen-network/cosmos-sdk#42](http://github.com/regen-network/cosmos-sdk/pull/42)) | ||
Add support for on-chain creation of Permanent Locked Accounts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be one line.
* ([#482](https://github.com/regen-network/regen-ledger/pull/482), | |
[regen-network/cosmos-sdk#42](http://github.com/regen-network/cosmos-sdk/pull/42)) | |
Add support for on-chain creation of Permanent Locked Accounts | |
* ([#482](https://github.com/regen-network/regen-ledger/pull/482), [regen-network/cosmos-sdk#42](http://github.com/regen-network/cosmos-sdk/pull/42)) Add support for on-chain creation of Permanent Locked Accounts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option: might be nice to use one line and put the fork link at the end.
* ([#482](https://github.com/regen-network/regen-ledger/pull/482), | |
[regen-network/cosmos-sdk#42](http://github.com/regen-network/cosmos-sdk/pull/42)) | |
Add support for on-chain creation of Permanent Locked Accounts | |
* [#482](https://github.com/regen-network/regen-ledger/pull/482) Add support for on-chain creation of Permanent Locked Accounts [regen-network/cosmos-sdk#42](http://github.com/regen-network/cosmos-sdk/pull/42) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These still render as a single line in the Markdown view. The multiline is only so that we keep line-width from being too long when viewing in an editor (so to make writing/editing of the changelog easier). I think I'd like to keep it as multiline, but like your suggestion of putting the fork PR at the end.
CHANGELOG.md
Outdated
@@ -6,23 +6,56 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## [Unreleased] | |||
|
|||
### Features | |||
## [v2.0.0-beta1](https://github.com/regen-network/regen-ledger/releases/tag/v2.0.0-beta1) - 2021-08-18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be updated if not merged tonight. ; )
Co-authored-by: Ryan Christoffersen <[email protected]>
…nto clevinson/v2.0-beta-changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -6,23 +6,56 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## [Unreleased] | |||
|
|||
### Features | |||
## [v2.0.0-beta1](https://github.com/regen-network/regen-ledger/releases/tag/v2.0.0-beta1) - 2021-08-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [v2.0.0-beta1](https://github.com/regen-network/regen-ledger/releases/tag/v2.0.0-beta1) - 2021-08-19 | |
## [v2.0.0-beta1](https://github.com/regen-network/regen-ledger/releases/tag/v2.0.0-beta1) - 2021-08-20 |
Co-authored-by: Anil Kumar Kammari <[email protected]>
Description
Updates CHANGELOG.md for v2.0.0. A tag (
v2.0.0-beta1
) will be made off of this merge commit.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change