Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix docker proto files generation #483

Merged
merged 5 commits into from
Aug 23, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Aug 17, 2021

Description

Closes: #427
Ref: 9854


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Makefile Outdated Show resolved Hide resolved
@aleem1314 aleem1314 marked this pull request as ready for review August 17, 2021 15:19
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #483 (9e2aa7f) into master (b9c083f) will not change coverage.
The diff coverage is n/a.

❗ Current head 9e2aa7f differs from pull request most recent head f5de2ef. Consider uploading reports for the commit f5de2ef to get more accurate results

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files         101      101           
  Lines       12531    12531           
=======================================
  Hits         9646     9646           
  Misses       2281     2281           
  Partials      604      604           
Flag Coverage Δ
experimental-codecov 76.97% <ø> (ø)
stable-codecov 61.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. A couple minor changes are made in go.mod and go.sum after running make proto-gen. We should maybe commit those changes in this pull request.

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that's it's a fix that doesn't hardcode "regen-ledger".

TBH I think this fix can be beneficial for other chains, what do you think of copying to the SDK too?

@robert-zaremba
Copy link
Collaborator

any reason we want to have different container for regen ledger? Now we are using the same image: tendermintdev/sdk-proto-gen:v0.2

@aleem1314
Copy link
Contributor Author

aleem1314 commented Aug 19, 2021

TBH I think this fix can be beneficial for other chains, what do you think of copying to the SDK too?

This issue was recently addressed on the SDK by PR#9854.

@amaury1093 amaury1093 enabled auto-merge (squash) August 23, 2021 09:22
@amaury1093 amaury1093 disabled auto-merge August 23, 2021 09:22
@amaury1093 amaury1093 enabled auto-merge (squash) August 23, 2021 09:22
@amaury1093 amaury1093 merged commit 9005905 into master Aug 23, 2021
@amaury1093 amaury1093 deleted the aleem/427-proto-build branch August 23, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker proto files generation not working properly
5 participants