-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): fix docker proto files generation #483
Conversation
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 76.97% 76.97%
=======================================
Files 101 101
Lines 12531 12531
=======================================
Hits 9646 9646
Misses 2281 2281
Partials 604 604
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. A couple minor changes are made in go.mod
and go.sum
after running make proto-gen
. We should maybe commit those changes in this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice that's it's a fix that doesn't hardcode "regen-ledger".
TBH I think this fix can be beneficial for other chains, what do you think of copying to the SDK too?
any reason we want to have different container for regen ledger? Now we are using the same image: tendermintdev/sdk-proto-gen:v0.2 |
This issue was recently addressed on the SDK by PR#9854. |
Description
Closes: #427
Ref: 9854
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change