Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Upgrade to 0.43-beta1 and integrate x/authz & x/feegrant into stable #349

Merged
merged 36 commits into from
May 19, 2021
Merged

build: Upgrade to 0.43-beta1 and integrate x/authz & x/feegrant into stable #349

merged 36 commits into from
May 19, 2021

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented May 13, 2021 •
edited by zube bot
Loading

ref: #336

@likhita-809 likhita-809 changed the title Upgrade to 0.43-beta1 and integrate x/authz & x/feegrant into stable build: Upgrade to 0.43-beta1 and integrate x/authz & x/feegrant into stable May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021 •
edited
Loading

Codecov Report

Merging #349 (de937f7) into master (0a13af3) will increase coverage by 1.18%.
The diff coverage is 81.13%.

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   59.35%   60.53%   +1.18%     
==========================================
  Files          10       10              
  Lines         647      674      +27     
==========================================
+ Hits          384      408      +24     
  Misses        255      255              
- Partials        8       11       +3

@likhita-809 likhita-809 marked this pull request as ready for review May 14, 2021 12:17
anilcse
anilcse reviewed May 14, 2021
View reviewed changes
Copy link
Contributor

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likhita-809 looks like the PR is still work-in progress. Why are we removing wasm integration?

app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/experimental_appconfig.go Outdated Show resolved Hide resolved
@likhita-809
Copy link
Contributor Author

likhita-809 commented May 14, 2021 •
edited
Loading

@likhita-809 looks like the PR is still work-in progress. Why are we removing wasm integration?

It looks like wasm is not upgraded with ibc modules

amaury1093
amaury1093 reviewed May 17, 2021
View reviewed changes
app/addr_prefixes.go Outdated Show resolved Hide resolved
amaury1093
amaury1093 reviewed May 17, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some small nits

app/addr_prefixes.go Outdated Show resolved Hide resolved
app/experimental_appconfig.go Outdated Show resolved Hide resolved
app/experimental_appconfig.go Outdated Show resolved Hide resolved
app/regen/cmd/genaccounts.go Outdated Show resolved Hide resolved
@amaury1093 amaury1093 mentioned this pull request May 17, 2021
Closed
2 tasks
atheeshp
atheeshp approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

amaury1093
amaury1093 approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also could run the node successfully

I still found some commented code, but that's okay I guess we can clean up later.

orm/orm_scenario_test.go Show resolved Hide resolved
x/group/server/testsuite/suite.go Outdated Show resolved Hide resolved
@amaury1093
Copy link
Contributor

@anilcse I think it's useful for you to take a look too before merging.

anilcse
anilcse reviewed May 18, 2021
View reviewed changes
app/experimental_appconfig.go Outdated Show resolved Hide resolved
app/regen/cmd/genaccounts.go Show resolved Hide resolved
@likhita-809 likhita-809 requested review from anilcse and aleem1314 May 19, 2021 06:24
anilcse
anilcse approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one comment

app/app.go Outdated Show resolved Hide resolved
anilcse
anilcse reviewed May 19, 2021
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
@amaury1093 amaury1093 merged commit 4cf57fc into master May 19, 2021
@amaury1093 amaury1093 deleted the likhita/authz-and-feegrant-integration branch May 19, 2021 08:34
@blushi blushi mentioned this pull request May 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilcse anilcse anilcse approved these changes

@atheeshp atheeshp atheeshp approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@cyberbono3 cyberbono3 Awaiting requested review from cyberbono3

@aaronc aaronc Awaiting requested review from aaronc

@blushi blushi Awaiting requested review from blushi

@clevinson clevinson Awaiting requested review from clevinson

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

@aleem1314 aleem1314 Awaiting requested review from aleem1314

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@likhita-809 @aaronc @anilcse @amaury1093 @atheeshp @aleem1314