feat: add x/group simulations #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 61.74% 61.39% -0.35%
==========================================
Files 48 50 +2
Lines 3100 3119 +19
==========================================
+ Hits 1914 1915 +1
- Misses 947 965 +18
Partials 239 239 |
aleem1314
commented
Feb 8, 2021
…into aleem/groups-simulations
…into aleem/groups-simulations
…into aleem/groups-simulations
…into aleem/groups-simulations
aleem1314
commented
Feb 25, 2021
atheeshp
reviewed
Apr 8, 2021
atheeshp
approved these changes
Apr 8, 2021
|
@anilcse could you have a final look at this when you have time so we can eventually merge it? Thanks. |
anilcse
reviewed
Apr 14, 2021
Co-authored-by: Anil Kumar Kammari <[email protected]>
|
@aleem1314 could you resolve the conflicts so we can merge when you have time? |
|
@anilcse are we good to merge this? |
Don't merge. One simulation job is failing. |
It seems like it's due to group invariants being broken, could you have a look when you have time @aleem1314? |
|
@anilcse can you take a final look? |
anilcse
approved these changes
May 5, 2021
|
@aleem1314 are we good to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #240