Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use official tag-expressions library #8

Merged
merged 2 commits into from
Jan 12, 2023
Merged

refactor: use official tag-expressions library #8

merged 2 commits into from
Jan 12, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 12, 2023

There is now an official tag parsing library which we can use instead of our custom one: https://pkg.go.dev/github.com/cucumber/tag-expressions/go/v5. This refactors gocuke to use that instead.

ryanchristo
ryanchristo approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@aaronc aaronc enabled auto-merge (squash) January 12, 2023 19:49
@aaronc aaronc merged commit 0c2109f into main Jan 12, 2023
@aaronc aaronc mentioned this pull request Jan 12, 2023
Merged
aaronc added a commit that referenced this pull request Jan 12, 2023
@aaronc
fix: fix build on main (#10)
3e43721 
Seems like #8 merged without CI passing. `build` wasn't required to
merge but is now. This includes fixes to the broken build caused by the
bad merge in #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanchristo ryanchristo ryanchristo approved these changes

@clevinson clevinson Awaiting requested review from clevinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronc @ryanchristo