Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] Upgrade remaining dependencies #2165

Merged

Conversation

kaaloo
Copy link
Contributor

@kaaloo kaaloo commented Jul 3, 2024

  • upgrade eslint to v8 (⚠️ need to wait on v9 until it's supported in client)
  • upgrade typescript-eslint packages
  • fix linting issues
  • upgrade typescript
  • miscellaneous upgrades

@@ -44,11 +44,11 @@ export const sendPublishedMailToStructureMembers = async (
lien: string,
dispositifId: Dispositif["_id"],
) =>
membres.map((membre) => {
Promise.all(membres.map(async (membre) => {
Copy link
Collaborator

@revolunet revolunet Jul 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style)

Suggested change
Promise.all(membres.map(async (membre) => {
Promise.all(membres.map((membre) => {

logger.info("[sendPublishedMailToStructureMembers] send mail to membre", {
membreId: membre._id,
});
return sendPublishedFicheMailToStructureMembersService({
await sendPublishedFicheMailToStructureMembersService({
Copy link
Collaborator

@revolunet revolunet Jul 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a style comment, as Promise.all accepts an array of promises you could return it directly without using async above.

Suggested change
await sendPublishedFicheMailToStructureMembersService({
return sendPublishedFicheMailToStructureMembersService({

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @revolunet! I simplified somewhat using the void operator.

@revolunet
Copy link
Collaborator

revolunet commented Jul 6, 2024

a github-action with a lint+build test could be handy :)

@kaaloo kaaloo requested a review from revolunet July 8, 2024 19:17
@kaaloo kaaloo merged commit 14d526f into dev Jul 9, 2024
1 check passed
@kaaloo kaaloo deleted the feat/#2123-Upgrade-Dependencies-next-server-dependencies branch July 9, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants