-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Server] Upgrade remaining dependencies #2165
[Server] Upgrade remaining dependencies #2165
Conversation
kaaloo
commented
Jul 3, 2024
•
edited
Loading
edited
- upgrade eslint to v8 (
⚠️ need to wait on v9 until it's supported in client) - upgrade typescript-eslint packages
- fix linting issues
- upgrade typescript
- miscellaneous upgrades
@@ -44,11 +44,11 @@ export const sendPublishedMailToStructureMembers = async ( | |||
lien: string, | |||
dispositifId: Dispositif["_id"], | |||
) => | |||
membres.map((membre) => { | |||
Promise.all(membres.map(async (membre) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(style)
Promise.all(membres.map(async (membre) => { | |
Promise.all(membres.map((membre) => { |
logger.info("[sendPublishedMailToStructureMembers] send mail to membre", { | ||
membreId: membre._id, | ||
}); | ||
return sendPublishedFicheMailToStructureMembersService({ | ||
await sendPublishedFicheMailToStructureMembersService({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a style comment, as Promise.all
accepts an array of promises you could return it directly without using async
above.
await sendPublishedFicheMailToStructureMembersService({ | |
return sendPublishedFicheMailToStructureMembersService({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @revolunet! I simplified somewhat using the void
operator.
a github-action with a lint+build test could be handy :) |