Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Ignore records with unset performance when grouping test cases #3247

Merged
merged 2 commits into from
Aug 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reframe/frontend/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -1662,8 +1662,8 @@ def module_unuse(*paths):
printer.error(message)

if errors.is_exit_request(*exc_info):
# Print stack traces for exit requests only when TOO verbose
printer.debug2(tb)
# Print stack traces for exit requests when debugging
printer.debug(tb)
elif errors.is_severe(*exc_info):
printer.error(tb)
else:
Expand Down
5 changes: 5 additions & 0 deletions reframe/frontend/reporting/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,11 @@ def _group_testcases(testcases, group_by, extra_cols):
for pvar, reftuple in tc['perfvalues'].items():
pvar = pvar.split(':')[-1]
pval, pref, plower, pupper, punit = reftuple
if pval is None:
# Ignore `None` performance values
# (performance tests that failed sanity)
continue

plower = pref * (1 + plower) if plower is not None else -math.inf
pupper = pref * (1 + pupper) if pupper is not None else math.inf
record = {
Expand Down
5 changes: 5 additions & 0 deletions unittests/resources/checks/frontend_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,15 @@ class NoPrgEnvCheck(BaseFrontendCheck):

@rfm.simple_test
class SanityFailureCheck(BaseFrontendCheck):
'''A performance test that fails in sanity.'''
@sanity_function
def validate_output(self):
return sn.assert_found('foo', self.stdout)

@performance_function('Gflop/s')
def perf(self):
return sn.extractsingle(r'perf: (\d+)', self.stdout, 1, int)
vkarak marked this conversation as resolved.
Show resolved Hide resolved


@rfm.simple_test
class PerformanceFailureCheck(BaseFrontendCheck):
Expand Down
Loading