-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Make processor model available through ProcessorInfo
#3150
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3150 +/- ##
========================================
Coverage 86.64% 86.65%
========================================
Files 61 61
Lines 12112 12112
========================================
+ Hits 10495 10496 +1
+ Misses 1617 1616 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add a short entry in docs/config_reference.rst
under "Processor Info"
I've added also corresponding entry for the devices which was also missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is a follow up of #3107 and defines the
model
attribute inProcessorInfo
.