Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Make processor model available through ProcessorInfo #3150

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Apr 2, 2024

This is a follow up of #3107 and defines the model attribute in ProcessorInfo.

@vkarak vkarak added this to the ReFrame 4.6 milestone Apr 2, 2024
@vkarak vkarak self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.65%. Comparing base (fe1c3b4) to head (072382d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3150   +/-   ##
========================================
  Coverage    86.64%   86.65%           
========================================
  Files           61       61           
  Lines        12112    12112           
========================================
+ Hits         10495    10496    +1     
+ Misses        1617     1616    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkarak vkarak requested a review from ekouts April 3, 2024 12:01
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add a short entry in docs/config_reference.rst under "Processor Info"

@vkarak
Copy link
Contributor Author

vkarak commented Apr 3, 2024

I would also add a short entry in docs/config_reference.rst under "Processor Info"

I've added also corresponding entry for the devices which was also missing.

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 2b158da into reframe-hpc:develop Apr 3, 2024
25 checks passed
@vkarak vkarak deleted the feat/processor-model branch April 3, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants