Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Do not fail if squeue cannot retrieve the reason that a job is pending #3123

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Feb 22, 2024

Closes #3122.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (972ffea) 86.63% compared to head (64a3e7a) 86.63%.

Files Patch % Lines
reframe/core/schedulers/slurm.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3123   +/-   ##
=======================================
  Coverage   86.63%   86.63%           
=======================================
  Files          61       61           
  Lines       12042    12042           
=======================================
  Hits        10432    10432           
  Misses       1610     1610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkarak vkarak merged commit ccd71f2 into reframe-hpc:master Feb 22, 2024
24 of 25 checks passed
@vkarak vkarak deleted the bugfix/squeue-failure branch February 22, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Query for the pending job reason using squeue may fail and erroneously report the test job as a failure
2 participants