[feat] Introduce launcher modifiers replacing LauncherWrapper
#3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3114 +/- ##
===========================================
+ Coverage 86.65% 86.67% +0.01%
===========================================
Files 61 61
Lines 12066 12082 +16
===========================================
+ Hits 10456 10472 +16
Misses 1610 1610 ☔ View full report in Codecov by Sentry. |
teojgo
requested changes
Feb 15, 2024
Co-authored-by: Theofilos Manitaras <[email protected]>
teojgo
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new variables in
JobLauncher:modifierandmodifier_options. These are combined and prepended to the emitted parallel launcher command. The use ofLauncherWrapperis depreceted.Closes #3100.