Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add nvcc as an environment configuration parameter #3098

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

OliverPerks
Copy link

This commit allows you to specify the path to nvidia's nvcc a part of a system environment. This allows for multiple environments with different paths to nvcc without the use of modules or the PATH environment. It allows for nvcc being unset in the environment and will default to 'nvcc'.

This commit allows you to specify the path to nvidia's nvcc a part of a system environment.
This allows for multiple environments with different paths to nvcc without the use of modules or the PATH environment.
It allows for nvcc being unset in the environment and will default to 'nvcc'.
@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@teojgo teojgo requested review from vkarak and teojgo January 25, 2024 15:11
@teojgo teojgo changed the title Adding nvcc as an environment parameter [feat] Adding nvcc as an environment parameter Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35fce1e) 86.63% compared to head (7580506) 86.63%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3098   +/-   ##
========================================
  Coverage    86.63%   86.63%           
========================================
  Files           61       61           
  Lines        12041    12042    +1     
========================================
+ Hits         10432    10433    +1     
  Misses        1609     1609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkarak vkarak changed the title [feat] Adding nvcc as an environment parameter [feat] Add nvcc as an environment configuration parameter Jan 30, 2024
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Lgtm. Just a minor comment.

reframe/core/environments.py Outdated Show resolved Hide resolved
reframe/core/systems.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR with the suggested changes, lgtm now.

@vkarak vkarak merged commit 5c136e8 into reframe-hpc:develop Jan 31, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants