-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add nvcc
as an environment configuration parameter
#3098
[feat] Add nvcc
as an environment configuration parameter
#3098
Conversation
This commit allows you to specify the path to nvidia's nvcc a part of a system environment. This allows for multiple environments with different paths to nvcc without the use of modules or the PATH environment. It allows for nvcc being unset in the environment and will default to 'nvcc'.
Can I test this patch? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3098 +/- ##
========================================
Coverage 86.63% 86.63%
========================================
Files 61 61
Lines 12041 12042 +1
========================================
+ Hits 10432 10433 +1
Misses 1609 1609 ☔ View full report in Codecov by Sentry. |
nvcc
as an environment configuration parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Lgtm. Just a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR with the suggested changes, lgtm now.
This commit allows you to specify the path to nvidia's nvcc a part of a system environment. This allows for multiple environments with different paths to nvcc without the use of modules or the PATH environment. It allows for nvcc being unset in the environment and will default to 'nvcc'.