remove getstate and setstate from Stack, and base argument from init #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a TODO in the Stack class, indicating that the custom
__getstate__
and__setstate__
methods might not be needed.These methods were making it difficult to subclass Stack without implementing even more specialized versions of the methods.
After removing them, deepcopy and serialize/deserialize seem to work fine.
Here is a test script to run and check. It shows that