Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize stdlib dataclasses #166

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Conversation

bmaranville
Copy link
Member

I don't think we need a custom schema decorator. We added keyword arguments "exclude" and "include" to the schema decorator, but they never ended up getting used, and there are other ways to solve that problem if it ever comes up.

Also, at some point stdlib dataclasses started supporting descriptor-based attributes. This removed the need for the complicated structure like

@schema(classname="Parameter")
class ParameterSchema:
    ...

class Parameter(ParameterSchema):
    ...

Need to check when that happened, to ensure compatibility.

@bmaranville bmaranville merged commit 6c58b28 into webview Dec 12, 2023
@glass-ships glass-ships deleted the serialize_stdlib_dataclasses branch September 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant