Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[In development] Add simple builder #164

Merged
merged 14 commits into from
Oct 26, 2023
Merged

[In development] Add simple builder #164

merged 14 commits into from
Oct 26, 2023

Conversation

mdoucet
Copy link
Contributor

@mdoucet mdoucet commented Oct 18, 2023

This is not for immediate merging. Work in progress.

Current issues:

  1. Parameter list doesn't update when adding a layer (which is done server-side at the moment). The model seems to update correctly (R(q) is updated).
  2. Need a button to remove a layer. Removing a layer works if you set its order number to -1.
  3. Need to pull in the css to make it pretty.
  4. Changing the name of a parameter in the model builder doesn't work.

This PR needs the following PR for bumps:
bumps/bumps#130

@mdoucet mdoucet requested a review from bmaranville October 18, 2023 20:16
@bmaranville bmaranville merged commit 44384a1 into webview Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants