-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 2450 globalize #2462
Fix issue 2450 globalize #2462
Conversation
@shioyama seems sane to me. So this will fail Travis until Globalize is released, is that correct? Should the gemspecs be updated in this pull request too? I like going from green to green if possible. Love your work. |
Yes, I merged the change to globalize 3-0-stable so all we need to do is release that as 3.0.1 and then update refinery to point to p.s. globalize needs a changelog. |
@shioyama I think I gave you gem push access for globalize.. I see your face: http://rubygems.org/gems/globalize |
I know I was just splitting the (very small) load 😉 |
+1 for this. Bit me in the tail today, but was happy to see so much activity on it. Thanks for your hard work. |
😖 (pulling hair out) Ok, one failing test which I don't see locally:
@parndt any clue what's going on? |
Ugh. I don't know sorry. This stuff is too magical in Refinery.. Sorry. |
Problem is that if I don't see the failure with the same environment locally, I have no way to debug it... can you run the tests and see if you get the same? At least that might provide a clue where the difference is. |
p.s. I've run the tests on two different environments on a linux pc and a mac, and see no failures... |
It may just be Travis.. I'll check this out over the next few days.. I'll be at RubyConf so a little preoccupied. |
Merged! Thanks, Chris |
globalize gem add a validation for locale field in translation table we should be explicit expose locale more details see refinery#140
This is needed to get refinery to work with the latest version of globalize for ActiveRecord 3.x, because globalize no-longer autosaves translations (see #2450). It requires globalize/globalize#296 to be released and the refinery gemspecs to also be updated from
globalize3 ~> 0.3.0
toglobalize ~> 3.0.0
.