fix: resources not being used up correctly when there are missing items #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now always makes it so that output resources are being added to the internal storage. If we do not do this, when there are missing resources, and we have the same ingredient being used multiple times, it would start from scratch for each of that same ingredient, causing a calculation that needs too many resources. So we have to *always* return resources so they can be reused later down the line, even if there are missing resources. However, we must use these resources up correctly if we do end up with missing resources! Otherwise, if another ingredient needs this resource later down the calculation, it will use them when it's not allowed to (the yields of the child calculation must be used up...)
raoulvdberge
force-pushed
the
NO-ISSUE/fix/calculation-bug
branch
from
c173636 to
6bd658a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now always makes it so that output resources are being added to the internal storage.
If we do not do this, when there are missing resources, and we have the same ingredient being used multiple times, it would start from scratch for each of that same
ingredient, causing a calculation that needs too many resources.
So we have to always return resources so they can be reused later down the line, even if there are missing resources. However, we must use these resources up correctly
if we do end up with missing resources!
Otherwise, if another ingredient needs this resource later down the calculation, it will use them when it's not allowed to (the yields of the child calculation must be used up...)
See #612