Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external storage not connecting properly to fluid storages #730

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

raoulvdberge
Copy link
Contributor

@raoulvdberge raoulvdberge commented Nov 30, 2024

No description provided.

@raoulvdberge raoulvdberge force-pushed the fix/NO-ISSUE/ext-storage branch from b869509 to 120c65c Compare November 30, 2024 13:17
Also fixes interface not respecting maximum stack size.
(Reproduceable in the Mekanism addon with creative chemical tank)

Also fixes crash potential crash when building cable shapes.
On Fabric it crashed with a ConcurrentModificationException.

This also no longer returns external
storages that have no capability active.
This fixes a bug where fluid storages were not detect, as items always came first.
@raoulvdberge raoulvdberge force-pushed the fix/NO-ISSUE/ext-storage branch from 120c65c to 93914bd Compare November 30, 2024 13:18
Copy link

@raoulvdberge raoulvdberge merged commit cf40335 into develop Nov 30, 2024
6 checks passed
@raoulvdberge raoulvdberge deleted the fix/NO-ISSUE/ext-storage branch November 30, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant