Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade refined architect #683

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

raoulvdberge
Copy link
Contributor

To fix issues with NeoForge asset
updating.

@raoulvdberge raoulvdberge force-pushed the chore/NO-ISSUE/upgrade-architect branch from 250f309 to be47e99 Compare September 9, 2024 18:27
To fix issues with NeoForge asset
updating.

With this change, every api module is now
compiled with the mod instead of using
the fabric jar-in-jar system.
The reason for this is for consistency
with neoforge, which always had the apis
compiled along with the main mod.

The only reason why we used jij on fabric
was for legacy reasons
 (RS 2 was originally made on fabric)
 and for inclusion
of the apis in modmenu.
But this is not important.
@raoulvdberge raoulvdberge force-pushed the chore/NO-ISSUE/upgrade-architect branch from be47e99 to ac09e65 Compare September 9, 2024 18:28
Copy link

sonarqubecloud bot commented Sep 9, 2024

@raoulvdberge raoulvdberge merged commit ec92d2a into develop Sep 9, 2024
6 checks passed
@raoulvdberge raoulvdberge deleted the chore/NO-ISSUE/upgrade-architect branch September 9, 2024 19:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant