Stack upgrade gametests #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoulvdberge
requested changes
Jul 12, 2024
...form-neoforge/src/test/java/com/refinedmods/refinedstorage/platform/common/GameTestUtil.java
Outdated
Show resolved
Hide resolved
...orge/src/test/java/com/refinedmods/refinedstorage/platform/common/exporter/ExporterTest.java
Outdated
Show resolved
Hide resolved
...orge/src/test/java/com/refinedmods/refinedstorage/platform/common/importer/ImporterTest.java
Outdated
Show resolved
Hide resolved
|
Can you add additional test for the constructor in item dropping mode w/ stack upgrade? (You can see the usages of the upgrades in |
|
Oh right I completely forgot that the constructor accepts stack upgrades too |
starforcraft
force-pushed
the
feat/GH-248/stacktests
branch
2 times, most recently
from
9b595f3 to
5e94fd4
Compare
raoulvdberge
requested changes
Jul 17, 2024
...form-neoforge/src/test/java/com/refinedmods/refinedstorage/platform/common/GameTestUtil.java
Outdated
Show resolved
Hide resolved
...form-neoforge/src/test/java/com/refinedmods/refinedstorage/platform/common/GameTestUtil.java
Show resolved
Hide resolved
...form-neoforge/src/test/java/com/refinedmods/refinedstorage/platform/common/GameTestUtil.java
Show resolved
Hide resolved
...form-neoforge/src/test/java/com/refinedmods/refinedstorage/platform/common/GameTestUtil.java
Show resolved
Hide resolved
starforcraft
force-pushed
the
feat/GH-248/stacktests
branch
3 times, most recently
from
743ee73 to
2897c5f
Compare
starforcraft
force-pushed
the
feat/GH-248/stacktests
branch
from
2897c5f to
d961e5f
Compare
raoulvdberge
approved these changes
Jul 18, 2024
|
Thx! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gametests #248
Stack Upgrade #69