feat: disk interface content #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoulvdberge
force-pushed
the
feat/GH-91/disk-interface
branch
from
315e340 to
223f63f
Compare
This corrects a mistake in 96841ec, where AbstractStorageContainerNetworkNode inherits from AbstractStorageNetworkNode. This would make it so that the disk interface has storage configuration properties like void excess etc. which is not intended! Now, AbstractStorageNetworkNode is removed and the duplication around the storage configuration is contained in StorageConfiguration. Also fixes relay having no help tooltip. Also fixes speed upgrades not working properly.
raoulvdberge
force-pushed
the
feat/GH-91/disk-interface
branch
from
223f63f to
b8b69b5
Compare
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #91
This corrects a mistake in 96841ec, where AbstractStorageContainerNetworkNode inherits from AbstractStorageNetworkNode.
This would make it so that the disk interface has storage configuration properties like void excess etc. which is not intended!
Now, AbstractStorageNetworkNode is removed and the duplication around the storage configuration is contained in StorageConfiguration.
Also fixes relay having no help tooltip.
Also fixes speed upgrades not working properly.