Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importer and exporter gametest #532

Closed
wants to merge 2 commits into from
Closed

Importer and exporter gametest #532

wants to merge 2 commits into from

Conversation

starforcraft
Copy link
Contributor

Gametests #248
Importer #65
Exporter #66

raoulvdberge
raoulvdberge requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@raoulvdberge raoulvdberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check the failed workflows.

.../main/java/com/refinedmods/refinedstorage2/platform/common/importer/ImporterBlockEntity.java Show resolved Hide resolved
...rge/src/test/java/com/refinedmods/refinedstorage2/platform/common/exporter/ExporterTest.java Show resolved Hide resolved
...rge/src/test/java/com/refinedmods/refinedstorage2/platform/common/exporter/ExporterTest.java Show resolved Hide resolved
...rge/src/test/java/com/refinedmods/refinedstorage2/platform/common/exporter/ExporterTest.java Show resolved Hide resolved
...rge/src/test/java/com/refinedmods/refinedstorage2/platform/common/exporter/ExporterTest.java Show resolved Hide resolved
...rge/src/test/java/com/refinedmods/refinedstorage2/platform/common/importer/ImporterTest.java Show resolved Hide resolved
...rge/src/test/java/com/refinedmods/refinedstorage2/platform/common/importer/ImporterTest.java Show resolved Hide resolved
...latform-forge/src/test/java/com/refinedmods/refinedstorage2/platform/forge/GameTestUtil.java Show resolved Hide resolved
...rge/src/test/java/com/refinedmods/refinedstorage2/platform/common/importer/ImporterTest.java Show resolved Hide resolved
...latform-forge/src/test/java/com/refinedmods/refinedstorage2/platform/forge/GameTestUtil.java Show resolved Hide resolved
@raoulvdberge
Copy link
Contributor

raoulvdberge commented May 27, 2024 •
edited
Loading

Try to squash all your commits into one and check the commit formatting (CONTRIBUTING.md)
Also your code isn't complying with the code style. Import the checkstyle file in Intellij (check CONTRIBUTING.md)

@starforcraft starforcraft deleted the branch refinedmods:develop May 27, 2024 07:56
@starforcraft starforcraft deleted the develop branch May 27, 2024 07:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raoulvdberge raoulvdberge raoulvdberge requested changes

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@starforcraft @raoulvdberge