feat: network transmitter #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The network transmitter now has an indicator on the block state whether the connection with the receiver is active. With not enough energy, it's inactive. Without network card or without connection, it's in errored state. Otherwise, it's in active state. The network transmitter will actively retry to reconnect if the connection is lost (for example due to chunk unloading).
This bug made it so that every time a network device is placed, it would trigger an extra update after the initial update to connect to an network. This extra update was caused by the fact that the device was going from inactive to active after the connection was made. We now only update the network if the direction has changed, since that is the only component that can influence graph scanning for now. This bug also caused some flickering with the network transmitter in combination with redstone mode.
raoulvdberge
force-pushed
the
feat/GH-97/network-transmitter
branch
from
0690b89 to
1c2323d
Compare
raoulvdberge
force-pushed
the
feat/GH-97/network-transmitter
branch
from
f447ecd to
f7de1e9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network transmitter now has an indicator
on the block state whether the connection with the receiver is active.
With not enough energy, it's inactive.
Without network card or without connection, it's in errored state. Otherwise, it's in active state.
The network transmitter will actively retry to reconnect if the connection is lost (for example due to chunk unloading).
Fixes #97