Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: network card #445

Merged
merged 2 commits into from
Nov 1, 2023
Merged

feat: network card #445

merged 2 commits into from
Nov 1, 2023

Conversation

raoulvdberge
Copy link
Contributor

Fixes #95

@raoulvdberge
refactor: make more classes package-private
dc0224f 
An added benefit of partitioning everything by feature.
@raoulvdberge raoulvdberge force-pushed the feat/GH-95/network-card branch from 9d51cac to 598a45c Compare November 1, 2023 00:59
@raoulvdberge raoulvdberge force-pushed the feat/GH-95/network-card branch from 598a45c to 60c0863 Compare November 1, 2023 10:03
@raoulvdberge raoulvdberge marked this pull request as ready for review November 1, 2023 10:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@raoulvdberge raoulvdberge merged commit a8ef002 into develop Nov 1, 2023
8 checks passed
@raoulvdberge raoulvdberge deleted the feat/GH-95/network-card branch November 1, 2023 10:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network Card
1 participant
@raoulvdberge