Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine input fluids get imported by importer #3570

Closed
loving2 opened this issue Sep 29, 2023 · 3 comments
Closed

Machine input fluids get imported by importer #3570

loving2 opened this issue Sep 29, 2023 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@loving2
Copy link

loving2 commented Sep 29, 2023

Describe the bug

Machine fluid inputs can be taken from with the importer. When this happens, the fluid input does not update with a new value of fluid remaining. This results in fluid duping.

The importer does not take input items, so I expected it to do nothing for input fluids as well.

I concluded this must lie in RS and not GTCEu-Modern because I could also pull the input fluid out of the machine by using Create's fluid pipes and pump, which did update the fluid remaining value in the machine's input.

How can we reproduce this bug or crash?

Unfortunately this requires a machine with a fluid input, in this instance it was found by testing with GregTechCEU Modern.

  1. Install GregTechCEU Modern version 1.0.12.f from CurseForge
  2. Install Refined Storage version 1.12.3
  3. Make a new world
  4. Set up an RS network with fluid storage
  5. Place a Basic Chemical Reactor from GT down
  6. Insert a bucket of rubber (or any other fluid) into any fluid input slot in the Basic Chemical Reactor
  7. Place an importer on the Basic Chemical Reactor, in Fluid mode
  8. Watch as you get infinite rubber (or any other fluid)

What Minecraft version is this happening on?

Minecraft 1.20.1

What Forge version is this happening on?

47.1.3

What Refined Storage version is this happening on?

refinedstorage-1.12.3

Relevant log output

No response

@loving2 loving2 added the bug Something isn't working label Sep 29, 2023
@raoulvdberge raoulvdberge added this to the v1.12.4 milestone Nov 4, 2023
@raoulvdberge
Copy link
Collaborator

Thank you! This has been fixed for the next RS release.
Gregtech will also be making a change as to not report these input slots as extractable.

raoulvdberge added a commit that referenced this issue Nov 12, 2023
The behavior is now consistent with items.
This caused issues with Gregtech, they returned fluids that weren't extractable in simulation mode so RS ended up duping them.
Now we only insert fluids that return from execution mode.

Fixes #3570

(cherry picked from commit 1522971)
@raoulvdberge
Copy link
Collaborator

This bug has been fixed in v1.12.4 for Minecraft 1.20.1 and v1.11.7 for Minecraft 1.19.2.
Thank you for reporting.

raoulvdberge added a commit that referenced this issue Nov 15, 2023
The behavior is now consistent with items.
This caused issues with Gregtech, they returned fluids that weren't extractable in simulation mode so RS ended up duping them.
Now we only insert fluids that return from execution mode.

Fixes #3570

(cherry picked from commit 1522971)
@raoulvdberge
Copy link
Collaborator

Hello, this bug is now also fixed for Minecraft 1.18.2 in v1.10.6.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants