fix: allow neoforge declaration without modid

refinedmods · Jul 23, 2024 · 6427f80 · 6427f80
1 parent ae388d1
commit 6427f80
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+### Fixed
+
+-  Declaring `neoForge()` without a `modId` set will not create a mod or run configs. Can be used for a NeoForge library module.
+
 ## [0.16.7] - 2024-07-20
 
 ### Fixed

diff --git a/refinedarchitect-plugin/src/main/kotlin/NeoForgeExtension.kt b/refinedarchitect-plugin/src/main/kotlin/NeoForgeExtension.kt
@@ -15,18 +15,20 @@ open class NeoForgeExtension(private val project: Project) : BaseExtension(proje
         project.extensions.getByType<NfExtension>().apply {
             version.set(neoForgeVersion)
             addModdingDependenciesTo(sourceSets["test"])
-            mods {
-                register(modId!!) {
-                    modSourceSets.set(listOf(sourceSets["main"], sourceSets["test"]))
-                }
-            }
-            runs {
-                register("client") {
-                    client()
+            if (modId != null) {
+                mods {
+                    register(modId!!) {
+                        modSourceSets.set(listOf(sourceSets["main"], sourceSets["test"]))
+                    }
                 }
-                register("server") {
-                    server()
-                    programArgument("--nogui")
+                runs {
+                    register("client") {
+                        client()
+                    }
+                    register("server") {
+                        server()
+                        programArgument("--nogui")
+                    }
                 }
             }
             parchment {