Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort pom files #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sort pom files #52

wants to merge 1 commit into from

Conversation

delanym
Copy link

@delanym delanym commented Feb 2, 2023

hi there!
I added a plugin execution to run in the validation phase of each module in the project.
The plugin sorts the pom.xml files inplace.
https://github.com/Ekryd/sortpom

I notice you've got a few security plugins, and maybe you're concerned and don't have the patience for validating a large change like this. In that case you could simply copy the plugin into your parent pom and run mvn validate. The committed changes should match exactly.

I'd like to make further PRs on the back of this foundation. Are you open to making JDK11 your base version? It would simplify the errorprone configuration for one.

@ghost
Copy link

ghost commented Feb 2, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant