Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: corrected showing product texts #15

Closed
wants to merge 1 commit into from
Closed

fix: corrected showing product texts #15

wants to merge 1 commit into from

Conversation

xeewii
Copy link
Contributor

@xeewii xeewii commented May 31, 2024

No description provided.

@xeewii xeewii requested a review from TorinAsakura May 31, 2024 00:47
@xeewii xeewii self-assigned this May 31, 2024
TorinAsakura
TorinAsakura requested changes May 31, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xeewii

  1. Откуда снейк-кейс в имени ветки?
  2. К какой задаче относится ПР? Где контекст?

@xeewii xeewii closed this May 31, 2024
@xeewii xeewii deleted the fix/stories_textsInUpdateProduct branch May 31, 2024 12:08
@xeewii
Copy link
Contributor Author

xeewii commented May 31, 2024

@TorinAsakura

  1. Не заметила правил именования в конвенции, только про написание коммитов, не подскажешь?
    И... переименовала ветку, однако пр слетел, вот новый - fix: corrected showing product texts #16
  2. Контекст добавила в описание нового пр'а

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorinAsakura TorinAsakura TorinAsakura requested changes

Assignees

@xeewii xeewii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xeewii @TorinAsakura