chore: Optimized imports

rees46 · Oct 4, 2024 · 6172da2 · 6172da2
1 parent 8a13f26
commit 6172da2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/.../main/kotlin/com/personalization/inAppNotification/view/component/image/AlertImageView.kt b/.../main/kotlin/com/personalization/inAppNotification/view/component/image/AlertImageView.kt
@@ -7,6 +7,7 @@ import androidx.appcompat.widget.AppCompatImageView
 import com.bumptech.glide.Glide
 import com.bumptech.glide.load.DataSource
 import com.bumptech.glide.load.engine.GlideException
+import com.bumptech.glide.request.RequestListener
 import com.bumptech.glide.request.RequestOptions
 import com.bumptech.glide.request.target.Target
 
@@ -22,7 +23,7 @@ class AlertImageView @JvmOverloads constructor(
                 .load(url)
                 .apply(RequestOptions().centerCrop())
                 .listener(
-                    object : com.bumptech.glide.request.RequestListener<Drawable> {
+                    object : RequestListener<Drawable> {
 
                         override fun onLoadFailed(
                             exception: GlideException?,

diff --git a/personalization-sdk/src/main/res/layout/alert_button_container.xml b/personalization-sdk/src/main/res/layout/alert_button_container.xml
@@ -8,10 +8,10 @@
 
     <androidx.cardview.widget.CardView
         android:layout_width="0dp"
-        android:layout_height="44dp"
-        android:layout_marginEnd="6dp"
+        android:layout_height="@dimen/button_height"
+        android:layout_marginEnd="@dimen/margin_small"
         android:layout_weight="1"
-        app:cardCornerRadius="8dp">
+        app:cardCornerRadius="@dimen/small_corner_radius">
 
         <com.personalization.inAppNotification.view.component.button.AlertButton
             android:id="@+id/buttonDecline"
@@ -26,10 +26,10 @@
 
     <androidx.cardview.widget.CardView
         android:layout_width="0dp"
-        android:layout_height="44dp"
-        android:layout_marginStart="6dp"
+        android:layout_height="@dimen/button_height"
+        android:layout_marginStart="@dimen/margin_small"
         android:layout_weight="1"
-        app:cardCornerRadius="8dp">
+        app:cardCornerRadius="@dimen/small_corner_radius">
 
         <com.personalization.inAppNotification.view.component.button.AlertButton
             android:id="@+id/buttonAccept"

diff --git a/personalization-sdk/src/main/res/values/styles.xml b/personalization-sdk/src/main/res/values/styles.xml
@@ -23,6 +23,9 @@
     <dimen name="default_margin">5dp</dimen>
     <dimen name="medium_margin">10dp</dimen>
     <dimen name="large_margin">20dp</dimen>
+    <dimen name="button_height">44dp</dimen>
+    <dimen name="small_corner_radius">8dp</dimen>
+    <dimen name="margin_small">6dp</dimen>
 
     <dimen name="product_image_size">150dp</dimen>
     <dimen name="product_margin">8dp</dimen>