Fixes for nightly #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing work, thank you for doing this. I've reviewed all the changes and everything looks good. Can you squash the commits so I can merge? |
The main changes specify object lifetimes. There are also small updates to track changes in Mio's `MioError` struct.
teotwaki
force-pushed
the
fixes-for-nightly
branch
from
82ddf2d
to
477350e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes some issues I've noticed while running the last nightly (
rustc 1.0.0-nightly (dfc5c0f1e 2015-02-18) (built 2015-02-19)). I don't fully understand the changes I've applied (mainly the'staticones), however the examples seem to run fine.SK on IRC indicated that the
'staticissue might be linked to rust-lang/rust#22319, which landed recently.Please let me know if you'd like some more tests.