This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Optional docker running #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps-jay
requested review from
bojan-ordev,
gyurikol,
HSPm,
jwettenhall and
guyjacksongit
ps-jay
force-pushed
the
optional-docker-running
branch
from
e8c959e to
de0629a
Compare
ps-jay
force-pushed
the
optional-docker-running
branch
from
de0629a to
b0d76cb
Compare
ps-jay
force-pushed
the
optional-docker-running
branch
from
4fc9565 to
5d30568
Compare
DanielAtanasovski
approved these changes
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed builds, since consuming workflows will not pre-build the
dockerimage whether the action is invoked or not (which most of the time at Reece it will not be invoked, since it's behind anif) - saving ~25s every build!The drawback is that
compositeactions have no ability to have apoststage - and thus automatic clean up of PATs will no longer occurThe workaround for the drawback is to explicitly revoke the token in the consuming workflow