Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: add clipping box #338

Merged
merged 18 commits into from
Nov 16, 2022
Merged

feat: add clipping box #338

merged 18 commits into from
Nov 16, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Oct 27, 2022

Overview

I added clipping box feature.
This clip the 3dtileset inside the box.

Clipping box plugin is here.

What I've done

  • Add clipping feature in Tileset component
  • Add the Box component
  • Add lookAt without animation

What I haven't done

  • The feature that scale the Box

How I tested

  1. Install the clipping-box-plugin
  2. And set position, tileset url, box color in the widget panel.
  3. Move the Box horizontally or vertically.

Screenshot

Screen.Recording.2022-10-28.at.23.05.40.mov

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Oct 27, 2022
@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit e533c15
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6370a4401d9dc40008b54735
😎 Deploy Preview https://deploy-preview-338--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #338 (e533c15) into main (9713238) will increase coverage by 0.14%.
The diff coverage is 39.72%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   18.23%   18.38%   +0.14%     
==========================================
  Files         512      514       +2     
  Lines       51248    51602     +354     
  Branches      639      640       +1     
==========================================
+ Hits         9344     9485     +141     
- Misses      41869    42082     +213     
  Partials       35       35              
Impacted Files Coverage Δ
src/components/molecules/Visualizer/Engine/ref.ts 0.00% <0.00%> (ø)
...rc/components/molecules/Visualizer/Plugin/types.ts 0.00% <0.00%> (ø)
...nents/molecules/Visualizer/Engine/Cesium/common.ts 42.65% <13.88%> (-1.56%) ⬇️
...lecules/Visualizer/Engine/Cesium/Tileset/index.tsx 23.49% <20.75%> (-5.30%) ⬇️
...molecules/Visualizer/Engine/Cesium/useEngineRef.ts 68.51% <25.00%> (-0.55%) ⬇️
...ts/molecules/Visualizer/Engine/Cesium/Box/Side.tsx 35.52% <35.52%> (ø)
...s/molecules/Visualizer/Engine/Cesium/Box/index.tsx 50.00% <50.00%> (ø)
...ents/molecules/Visualizer/Engine/Cesium/builtin.ts 100.00% <100.00%> (ø)
src/util/value.ts 65.29% <100.00%> (+7.28%) ⬆️

@keiya01 keiya01 marked this pull request as ready for review October 28, 2022 14:08
src/util/value.ts Outdated Show resolved Hide resolved
@keiya01 keiya01 enabled auto-merge (squash) November 13, 2022 08:01
@keiya01 keiya01 merged commit af55f1a into main Nov 16, 2022
@keiya01 keiya01 deleted the feature/box-api branch November 16, 2022 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants