Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add some functionalities for pedestrian #862

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Dec 18, 2023

Overview

I added some functionalities for pedestrian.

What I've done

  • convertScreenToPositionOffset ... Calculate the distance of coordinates from currentxyz coordinates to window position.
  • isPositionVisible ... Check the position is on globe
  • setView ... Set camera includes fov without unnecessary calculation
  • toWindowPosition ... Convert xyz coordinates to window position.
  • Ellipse appearance ... Show plane circle

What I haven't done

How I tested

You should use eukarya-inc/PLATEAU-VIEW-3.0#112 to test this PR.

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 6ee7e58
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/657fef8d804508000833bae4
😎 Deploy Preview https://deploy-preview-862--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #862 (6ee7e58) into main (02aac2b) will decrease coverage by 0.01%.
The diff coverage is 19.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   25.85%   25.84%   -0.01%     
==========================================
  Files        1645     1646       +1     
  Lines      181457   181738     +281     
  Branches     3889     3889              
==========================================
+ Hits        46909    46965      +56     
- Misses     133459   133684     +225     
  Partials     1089     1089              
Flag Coverage Δ
web 24.11% <19.92%> (-0.01%) ⬇️
web-beta 24.11% <19.92%> (-0.01%) ⬇️
web-classic 24.11% <19.92%> (-0.01%) ⬇️
web-utils 24.11% <19.92%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/Map/ref.ts 88.13% <100.00%> (+0.41%) ⬆️
...src/beta/lib/core/engines/Cesium/Feature/index.tsx 34.74% <100.00%> (+0.55%) ⬆️
web/src/beta/lib/core/mantle/types/appearance.ts 100.00% <100.00%> (ø)
web/src/beta/lib/core/engines/index.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/Plugins/storybook.tsx 0.00% <0.00%> (ø)
...eb/src/beta/lib/core/Crust/Plugins/plugin_types.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/Map/types/index.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/Plugins/api.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/Plugins/hooks.ts 0.00% <0.00%> (ø)
.../lib/core/engines/Cesium/Feature/Ellipse/index.tsx 27.65% <27.65%> (ø)
... and 1 more

@keiya01 keiya01 requested review from airslice and removed request for mkumbobeaty December 18, 2023 05:15
@keiya01 keiya01 merged commit 293335b into main Dec 18, 2023
16 checks passed
@keiya01 keiya01 deleted the feat/pedestrian-functionalities branch December 18, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants