Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): timeline with padding #853

Merged
merged 21 commits into from
Dec 22, 2023
Merged

chore(web): timeline with padding #853

merged 21 commits into from
Dec 22, 2023

Conversation

mkumbobeaty
Copy link
Contributor

@mkumbobeaty mkumbobeaty commented Dec 5, 2023

Overview

What I've done

  • Fix on click for the timeline block after page padding set
  • Fix UI for timeline block after block padding

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 8820171
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6584d8da5352490008bf8183
😎 Deploy Preview https://deploy-preview-853--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 176 lines in your changes are missing coverage. Please review.

Comparison is base (1468728) 26.06% compared to head (abdd4ca) 25.55%.

❗ Current head abdd4ca differs from pull request most recent head 8820171. Consider uploading reports for the commit 8820171 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   26.06%   25.55%   -0.51%     
==========================================
  Files        1653     1644       -9     
  Lines      182934   181200    -1734     
  Branches     3890     3920      +30     
==========================================
- Hits        47677    46309    -1368     
+ Misses     134168   133802     -366     
  Partials     1089     1089              
Flag Coverage Δ
web 23.75% <0.00%> (-0.65%) ⬇️
web-beta 23.75% <0.00%> (-0.65%) ⬇️
web-classic 23.75% <0.00%> (-0.65%) ⬇️
web-utils 23.75% <0.00%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/utils.ts 0.00% <0.00%> (ø)
...b/core/StoryPanel/Block/builtin/Timeline/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Block/types.ts 0.00% <0.00%> (ø)
...lib/core/StoryPanel/Block/builtin/Timeline/hook.ts 0.00% <0.00%> (ø)
.../core/StoryPanel/Block/builtin/Timeline/Editor.tsx 0.00% <0.00%> (ø)

... and 142 files with indirect coverage changes

@mkumbobeaty mkumbobeaty merged commit a16870e into main Dec 22, 2023
12 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/timeline-ux branch December 22, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants