Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Improve asset modal #838

Merged
merged 14 commits into from
Nov 28, 2023
Merged

chore(web): Improve asset modal #838

merged 14 commits into from
Nov 28, 2023

Conversation

mkumbobeaty
Copy link
Contributor

@mkumbobeaty mkumbobeaty commented Nov 27, 2023

Overview

What I've done

  • fix source type order (From Asset, From web, From Value)
  • Improve asset modal file Choice and upload based of selected file format
Screencast.from.27-11-2023.04.35.02.ALASIRI.webm
Screencast.from.27-11-2023.04.33.54.ALASIRI.webm

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 52f6eed
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65658cb7596d45000829c2ce
😎 Deploy Preview https://deploy-preview-838--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 27, 2023
@github-actions github-actions bot requested a review from pyshx November 27, 2023 14:10
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #838 (52f6eed) into main (1b79cfb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   25.65%   25.64%   -0.01%     
==========================================
  Files        1640     1640              
  Lines      180458   180491      +33     
  Branches     3916     3915       -1     
==========================================
- Hits        46291    46290       -1     
- Misses     133078   133112      +34     
  Partials     1089     1089              
Flag Coverage Δ
web 23.86% <0.00%> (-0.01%) ⬇️
web-beta 23.86% <0.00%> (-0.01%) ⬇️
web-classic 23.86% <0.00%> (-0.01%) ⬇️
web-utils 23.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/beta/features/Editor/DataSourceManager/index.tsx 0.00% <ø> (ø)
web/src/beta/features/Assets/types.ts 0.00% <0.00%> (ø)
web/src/beta/components/fields/URLField/index.tsx 0.00% <0.00%> (ø)
web/src/beta/hooks/useAssetUploader/hooks.tsx 0.00% <0.00%> (ø)
...s/Editor/DataSourceManager/DelimitedText/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Modals/AssetModal/index.tsx 0.00% <0.00%> (ø)
...features/Editor/DataSourceManager/Common/index.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@mkumbobeaty mkumbobeaty enabled auto-merge (squash) November 28, 2023 07:07
@mkumbobeaty mkumbobeaty merged commit 68c18da into main Nov 28, 2023
15 of 16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/layer-bug-fix branch November 28, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants