Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): core marker extrude check for coordinates height #834

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

airslice
Copy link
Contributor

Overview

This PR fixs the check for coordinates height of marker extrudePoints in both classic core and beta core.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@airslice airslice self-assigned this Nov 24, 2023
Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 56b17de
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65603ec084ccca0008397287
😎 Deploy Preview https://deploy-preview-834--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #834 (56b17de) into main (b60713b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #834   +/-   ##
=======================================
  Coverage   25.68%   25.68%           
=======================================
  Files        1637     1637           
  Lines      180169   180169           
  Branches     3911     3912    +1     
=======================================
+ Hits        46284    46285    +1     
+ Misses     132796   132795    -1     
  Partials     1089     1089           
Flag Coverage Δ
web 23.91% <0.00%> (+<0.01%) ⬆️
web-beta 23.91% <0.00%> (+<0.01%) ⬆️
web-classic 23.91% <0.00%> (+<0.01%) ⬆️
web-utils 23.91% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/lib/core/engines/Cesium/Feature/Marker/index.tsx 13.90% <0.00%> (ø)
...assic/core/engines/Cesium/Feature/Marker/index.tsx 14.01% <0.00%> (ø)

... and 1 file with indirect coverage changes

@airslice airslice merged commit 7fcaa22 into main Nov 24, 2023
16 checks passed
@airslice airslice deleted the chore/core-marker-extrude branch November 24, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants