Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix story block bugs #829

Merged
merged 14 commits into from
Nov 26, 2023
Merged

chore(web): fix story block bugs #829

merged 14 commits into from
Nov 26, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • Double click block to enter edit mode any time
  • fix First page top-left to show Page instead Untitled
  • Remove Block outline movable cursor
  • Fix jump out of edit mode while editing the block

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 27932d7
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/656397e2dbcb7200088d219d
😎 Deploy Preview https://deploy-preview-829--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 22, 2023
@mkumbobeaty mkumbobeaty changed the title Chore/fix block chore(web): fix story block bugs Nov 22, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #829 (27932d7) into main (7fcaa22) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   25.69%   25.68%   -0.01%     
==========================================
  Files        1637     1637              
  Lines      180169   180197      +28     
  Branches     3913     3913              
==========================================
- Hits        46288    46286       -2     
- Misses     132792   132822      +30     
  Partials     1089     1089              
Flag Coverage Δ
web 23.90% <0.00%> (-0.01%) ⬇️
web-beta 23.90% <0.00%> (-0.01%) ⬇️
web-classic 23.90% <0.00%> (-0.01%) ⬇️
web-utils 23.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/lib/core/StoryPanel/Block/types.ts 0.00% <0.00%> (ø)
...rc/beta/lib/core/StoryPanel/PanelContent/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/index.tsx 0.00% <0.00%> (ø)
...lib/core/StoryPanel/Block/builtin/Timeline/hook.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)
...b/core/StoryPanel/Block/builtin/common/Wrapper.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/components/DragAndDropList/Item.tsx 0.00% <0.00%> (ø)
.../lib/core/StoryPanel/Block/builtin/common/hooks.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@mkumbobeaty mkumbobeaty merged commit d6bf3ef into main Nov 26, 2023
15 of 16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/fix-block branch November 26, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants