Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): fix story page bugs #826

Merged
merged 11 commits into from
Nov 23, 2023
Merged

chore(web): fix story page bugs #826

merged 11 commits into from
Nov 23, 2023

Conversation

mkumbobeaty
Copy link
Contributor

Overview

What I've done

  • Fix double click the page name to edit page name
  • Fix spacing/gap between title and the first block

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 2e1c112
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/655eefeed40a730008786ea8
😎 Deploy Preview https://deploy-preview-826--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #826 (2e1c112) into main (91a8215) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   25.69%   25.69%   -0.01%     
==========================================
  Files        1637     1637              
  Lines      180174   180169       -5     
  Branches     3913     3912       -1     
==========================================
- Hits        46290    46287       -3     
+ Misses     132795   132793       -2     
  Partials     1089     1089              
Flag Coverage Δ
web 23.91% <0.00%> (-0.01%) ⬇️
web-beta 23.91% <0.00%> (-0.01%) ⬇️
web-classic 23.91% <0.00%> (-0.01%) ⬇️
web-utils 23.91% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Editor/tabs/story/LeftPanel/ContentPage/index.tsx 0.00% <ø> (ø)
...res/Editor/tabs/map/LeftPanel/Layers/LayerItem.tsx 0.00% <0.00%> (ø)
...itor/tabs/story/LeftPanel/ContentPage/PageItem.tsx 0.00% <0.00%> (ø)
...features/Editor/DataSourceManager/Common/index.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@mkumbobeaty mkumbobeaty merged commit 09338f5 into main Nov 23, 2023
15 of 16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/double-click-page branch November 23, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants